Skip to content

Use load context with timeout #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

Use load context with timeout #88

merged 2 commits into from
Sep 25, 2025

Conversation

bdjilka
Copy link
Contributor

@bdjilka bdjilka commented Sep 23, 2025 •
edited
Loading

Add timeout to load context

Summary

As ziti-idk-c now supports specifying a timeout to load an OpenZiti context, a related change was made to use corresponding method in Python SDK.

Details
Timeout argument is optional, so openziti.load(...) can be used as before.
Currently ziti-sdk-c hasn't release a new version with changes, so this PR is blocked until version 1.9.1 will appear.

To set timeout the proposal is to introduce new optional key timeout to bindings:

bindings = {
   ('0.0.0.0', 8080): { 'ztx': 'my-identity.json', 'service':'my-service', 'timeout': 1000 }
}

Unfortunately https://netfoundry.io/docs/openziti/policies/CONTRIBUTING.html right now returns "Page not found", so I can't proceed with signing CLA

@bdjilka bdjilka requested a review from a team as a code owner September 23, 2025 14:13
@bdjilka bdjilka changed the title Use load context with timeout [WIP] Use load context with timeout Sep 23, 2025
@bdjilka bdjilka changed the title [WIP] Use load context with timeout Use load context with timeout Sep 23, 2025
@bdjilka
Copy link
Contributor Author

bdjilka commented Sep 24, 2025

Hello @ekoby! As you can see a workflow fails with:
OpenID Connect token retrieval failed: GitHub: missing or insufficient OIDC token permissions, the ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variable was unset

I assume that's because pr is created from a forked repo. Can you assist with it?

@ekoby
Copy link
Member

ekoby commented Sep 25, 2025

Unfortunately https://netfoundry.io/docs/openziti/policies/CONTRIBUTING.html right now returns "Page not found", so I can't proceed with signing CLA

CLA page should be OK now. Please submit it

@ekoby
Copy link
Member

ekoby commented Sep 25, 2025 •
edited
Loading

I assume that's because pr is created from a forked repo.

Publishing step should fail for third party forks (otherwise it is not secure). this failure can be ignored.

I disabled that step for external PRs. the jobs should complete now (after you rebase)

@bdjilka bdjilka force-pushed the use_load_context_with_timeout branch from 2a1b3fa to 0caa3e9 Compare September 25, 2025 14:20
ekoby
ekoby approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@ekoby ekoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just waiting for the signed CLA

@bdjilka
Copy link
Contributor Author

bdjilka commented Sep 25, 2025 •
edited
Loading

looks good, just waiting for the signed CLA

Sent CLA around 3 hours ago to cla@netfoundry.io

@ekoby ekoby merged commit e5e42b2 into openziti:main Sep 25, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekoby ekoby ekoby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdjilka @ekoby